GitHub Contributing

StrangeOne101 · Oct 14, 2017

xNuminousx said:
Do I have to install something Maven related as an Eclipse plugin? I get the Java Application option but I didn't show it because it wasn't what you were listing. The Java Application is all that's listed.

Maybe you got the wrong version of eclipse, I don't know ¯\_(ツ)_/¯

xNuminousx · Oct 14, 2017

StrangeOne101 said:
Maybe you got the wrong version of eclipse, I don't know ¯\_(ツ)_/¯

I use Oxygen.
PS Added a screenshot in my previous reply.

xNuminousx · Oct 14, 2017

Oh well, I probably shouldn't be contributing anyways. I had a fix for FireManipulation and wanted to test it and that's when I found the errors. I'll just PR and someone else can tell me if it doesn't work.

StrangeOne101 · Oct 14, 2017

I'm not 100% sure why you don't have it but my guess is that you installed the other type of Java eclipse. There's two: one that supports Java, Maven, and a few other java related things and the other one, which supports other languages too.

Look on the eclipse marketplace as you may be able to get the stuff there. But I'm not sure. Sorry

xNuminousx · Oct 14, 2017

StrangeOne101 said:
I'm not 100% sure why you don't have it but my guess is that you installed the other type of Java eclipse. There's two: one that supports Java, Maven, and a few other java related things and the other one, which supports other languages too.

Look on the eclipse marketplace as you may be able to get the stuff there. But I'm not sure. Sorry

Thanks for your help!

xNuminousx · Oct 14, 2017

Upon searching through the preferences, desperately, I found a Maven section. Potentially of use?

Screen Shot 2017-10-14 at 6.00.26 PM.png

Sobki · Oct 14, 2017

Are you sure you have converted your project to be a Maven project?

Right-click ProjectKorra > Configure > Convert to Maven Project

xNuminousx · Oct 14, 2017

Sobki said:
Are you sure you have converted your project to be a Maven project?

Right-click ProjectKorra > Configure > Convert to Maven Project

No because I didn't know I was supposed to convert anything.

Sobki · Oct 14, 2017

ProjectKorra uses Maven so it needs to be set up as a Maven project. Do that and then try to Maven Install.

xNuminousx · Oct 14, 2017

Okay so Sobki was right, the maven stuff showed up. I clicked Maven Install and a console appeared and is now spitting TONS of stuff. Now what? How does this solve the problem?

Jar exporting now fails so I don't assume it's business as usual.

StrangeOne101 · Oct 14, 2017

It could be a lot of things. Maven is annoying, but post your errors anyway.

xNuminousx · Oct 14, 2017

StrangeOne101 said:
It could be a lot of things. Maven is annoying, but post your errors anyway.

I didn't get any errors, as I said the exporting failed so it never made it to jar form. I'll try again later and update the thread.

StrangeOne101 · Oct 14, 2017

xNuminousx said:
I didn't get any errors, as I said the exporting failed so it never made it to jar form. I'll try again later and update the thread.

If it failed to export, Maven will give an error lol

Loony · Oct 15, 2017

Yeah you need to convert to maven first like Sobki said, then build a jar from maven

StrangeOne101 · Oct 21, 2017

@xNuminousx If Maven fails to export, it should give you an error. It's not a stracktrace like a Java runtime exception, but it's still an error. You might have what happened to me and have some Maven jars corrupted.

xNuminousx · Oct 21, 2017

Well I checked the console that pops up when you do Maven Install and nothing new happens. And the same ol' error happens in the minecraft console for regular exporting.

StrangeOne101 · Oct 21, 2017

Since you really can't see it, paste the entire Maven install log

xNuminousx · Oct 21, 2017

I restarted eclipse and it's exporting now.

xNuminousx · Oct 27, 2017

Finally took time to get the warning log, here it is:
https://pastebin.com/8CQKf55Z

PS: Just to be clear, I click Maven Install, the console pops up, when it finishes it's task I export it like normal? I feel like there's a different way I'm supposed to be exporting that I'm not seeing. This is my first time dealing with Maven obviously.

Edit
By looking at the log, it reads as a directory error.... Would I have to add those build paths myself?

StrangeOne101 · Oct 27, 2017

xNuminousx said:
Finally took time to get the warning log, here it is:
https://pastebin.com/8CQKf55Z

PS: Just to be clear, I click Maven Install, the console pops up, when it finishes it's task I export it like normal? I feel like there's a different way I'm supposed to be exporting that I'm not seeing. This is my first time dealing with Maven obviously.

Those warnings are normal, but you are looking for the big

Code:

--------------------
 BUILD SUCCESS
-----------------------

or something. If it doesn't say that, does it say build fail? If so, there will be an error above that and that's what we need

If it does succeed, then the jar can be found in /target/ProjectKorra-1.8.X.jar