• Hello Guest! Did you know that ProjectKorra has an official Discord server? A lot of discussion about the official server, development process, and community discussion happens over there. Feel free to join now by clicking the link below.

    Join the Discord Server

GitHub Contributing

xNuminousx

xNuminousx

Verified Member
ookaayyy So I've run into a dilemma. I know that ProjectKorra doesn't do to well on 1.12 due to the fabulous Spigot so I've tried staying clear of that. However, I've imported PK into Eclipse through 3 different branches yet each of them have the 1.12 Spigot build path AND break a server. Idk if it's my GitHub ignorance setting in or what but I cannot test my own personal edits because when exporting the GitHub clone it breaks the server.

I've tried importing using the wip branch, master branch, and the PK-1.8.0-MC-1.10 branch. Each including the the spigot 1.12 build path (which I find very suspicious and leads me to believe I'm doing something wrong). PLUS (just a bonus for ya) when changing the build path on my own it completely ruins the whole thing. I assume THAT has something to do with the directory for my personal jar.

Any advice or help? (Don't inform me I don't know what I'm doing because my server console has told me that enough).
 
StrangeOne101

StrangeOne101

Staff member
Plugin Developer
Moderator
Verified Member
PK's dependencies come from maven, so you can't actually change them like you would for a normal projects build path. What I don't understand is why you are trying to change it? PK is made for spigot 1.12 so I don't see the issue
 
xNuminousx

xNuminousx

Verified Member
StrangeOne101 said:
PK's dependencies come from maven, so you can't actually change them like you would for a normal projects build path. What I don't understand is why you are trying to change it? PK is made for spigot 1.12 so I don't see the issue
Click to expand...
The issue has been that any branch I've cloned has broken the plugin. The error exists in CoreAbility, more specifically where the registerAbilites method is. I had the same issue when workin on the original concept for Spirits and that was part of the reason I had to keep from making Spirits a plugin, because the CoreAbility register is jacked up in 1.12. I want to change the build path because I assume that's what's causing the issue.
 
StrangeOne101

StrangeOne101

Staff member
Plugin Developer
Moderator
Verified Member
xNuminousx said:
The issue has been that any branch I've cloned has broken the plugin. The error exists in CoreAbility, more specifically where the registerAbilites method is. I had the same issue when workin on the original concept for Spirits and that wasn't part of the reason I had to keep from making Spirits a plugin, because the CoreAbility register is jacked up in 1.12. I want to change the build path because I assume that's what's causing the issue.
Click to expand...
That's rather odd, because there shouldn't be an issue. You are using Java 8, correct? PK doesn't support Java 7 anymore since vanilla Minecraft doesn't support that anymore anyway. It's possible PK code there is Java 8 only
 
xNuminousx

xNuminousx

Verified Member
StrangeOne101 said:
That's rather odd, because there shouldn't be an issue. You are using Java 8, correct? PK doesn't support Java 7 anymore since vanilla Minecraft doesn't support that anymore anyway. It's possible PK code there is Java 8 only
Click to expand...
That could be it. I haven't checked Java version in a while.
 
xNuminousx

xNuminousx

Verified Member
Okay so I went back and looked at what Omni told me from when he was helping me with Spirits. He said that the AbilityLoader needed to be updated for 1.12 because spigot upped their java/guava version which broke some code. Idk if that means anything to you or if you know what he's talking about, but that's what he's told me about a similar issue.
 
StrangeOne101

StrangeOne101

Staff member
Plugin Developer
Moderator
Verified Member
xNuminousx said:
Okay so I went back and looked at what Omni told me from when he was helping me with Spirits. He said that the AbilityLoader needed to be updated for 1.12 because spigot upped their java/guava version which broke some code. Idk if that means anything to you or if you know what he's talking about, but that's what he's told me about a similar issue.
Click to expand...
I was the one that updated it so I know a fair bit about it. But yeah, he's right. 1.12 updated a library that minecraft uses that we also happened to use, and they removed a bit of code that we used to load abilities. As such, the system had to be updated lol.

Can you show me the error you get on it though? I still find it very intriguing that it isn't working.
 
xNuminousx

xNuminousx

Verified Member
StrangeOne101 said:
Actually, is the error you are referring to in YOUR plugin and not PK?
Click to expand...
No, I get the error when I export code from a PK branch into the server. The errors in the console state the Pk was unable to load because of the CoreAbility register. It's the same error I got for Spirits only instead of it being spirits, it's Pk now. I'll get the error for ya.
 
StrangeOne101

StrangeOne101

Staff member
Plugin Developer
Moderator
Verified Member
xNuminousx said:
No, I get the error when I export code from a PK branch into the server. The errors in the console state the Pk was unable to load because of the CoreAbility register. It's the same error I got for Spirits only instead of it being spirits, it's Pk now. I'll get the error for ya.
Click to expand...
Then it sounds like you aren't exporting with Maven. If the plugin isn't built with Maven, it ain't gonna work.

You need to right click the Project -> Run As -> Maven Install
 
xNuminousx

xNuminousx

Verified Member
Do I have to install something Maven related as an Eclipse plugin? I get the Java Application option but I didn't show it because it wasn't what you were listing. The Java Application is all that's listed.

Edit:
Screen Shot 2017-10-14 at 5.38.40 PM.png
 
You must log in or register to reply here.
Top