Ability hurts myself and disappears

[Gareth Swan]

Hey so I have 2 issues with an ability I'm working on.
Firstly, even after adding:

        for (Entity entity : GeneralMethods.getEntitiesAroundPoint(location, collisionRadius)) {
            if (entity instanceof Entity && entity.getUniqueId() != player.getUniqueId()) {
                DamageHandler.damageEntity(entity, player, damage, this);
                remove();
                return;

The ability can still hurt myself. And secondly, if I look straight forward or down a bit when using the ability, it doesn't progress forward and just disappears. It displays one flash of the particles and plays the sound but then disappears

 

[Loony]

Hey so I have 2 issues with an ability I'm working on.
Firstly, even after adding:

        for (Entity entity : GeneralMethods.getEntitiesAroundPoint(location, collisionRadius)) {
            if (entity instanceof Entity && entity.getUniqueId() != player.getUniqueId()) {
                DamageHandler.damageEntity(entity, player, damage, this);
                remove();
                return;

The ability can still hurt myself. And secondly, if I look straight forward or down a bit when using the ability, it doesn't progress forward and just disappears. It displays one flash of the particles and plays the sound but then disappears

Try adding an else statement with a return & a broadcast

 

[Simplicitee]

Hey so I have 2 issues with an ability I'm working on.
Firstly, even after adding:

        for (Entity entity : GeneralMethods.getEntitiesAroundPoint(location, collisionRadius)) {
            if (entity instanceof Entity && entity.getUniqueId() != player.getUniqueId()) {
                DamageHandler.damageEntity(entity, player, damage, this);
                remove();
                return;

The ability can still hurt myself. And secondly, if I look straight forward or down a bit when using the ability, it doesn't progress forward and just disappears. It displays one flash of the particles and plays the sound but then disappears

Use getEntityId instead of getUniqueId

 

[Sobki]

Use getEntityId instead of getUniqueId

entities have unique ids too so that does work ^ that's how I use it

 

[Simplicitee]

entities have unique ids too so that does work ^ that's how I use it

Ik I'm just saying he should try it, see if that changes it at all.

 

[Simplicitee]

Also you shouldn't do 'entity instanceof Entity', that's a redundant check because the list is already Entity

 

[xNuminousx]

lays one flash of the particles and plays the sound but then disappears

Are you still having issues with this animation bit? Does it display 1 tick worth of particles then stop?

 

[StrangeOne101]

As @Simplicitee said, you shouldn't be testing if entity is an instanceof Entity. You need to test for a LivingEntity. LivingEntities are the ones we want to damage (other ones are things like items, arrows, paintings, etc).

I also recommend doing !entity.getUniqueId().equals(player.getUniqueId()) instead of
entity.getUniqueId() != player.getUniqueId(). Try that.

 

[Gareth Swan]

As @Simplicitee said, you shouldn't be testing if entity is an instanceof Entity. You need to test for a LivingEntity. LivingEntities are the ones we want to damage (other ones are things like items, arrows, paintings, etc).

I also recommend doing !entity.getUniqueId().equals(player.getUniqueId()) instead of
entity.getUniqueId() != player.getUniqueId(). Try that.

Thank you! I'll give that a go