Fixed Day/night enhancement messages are sometimes spammed to players

[Snhnry]

Version: 1.2.0 release

I've been unable to replicate this or even get a screenshot of it happening, but multiple players are reporting that sometimes the day/night messages for fire and water are spammed into their chat hundreds of times when the sun is setting or rising.

It doesn't seem to have any consistency, and happens fairly infrequently, maybe one out of every 50 day/night cycles

 

[Mist]

I haven't had this happen and fire / water are my main elements. If it is something you run across again, if you could get an error log, that would be fantastic.

 

[Snhnry]

Unfortunately, as far as I can tell, it only manifests to the client. I've been unable to find any errors that occur at the same time.

 

[Snhnry]

Here is a screenshot. http://i.imgur.com/uwns1tg.png Tabbychat is consolidating hundreds of the messages and still being spammed. Around the time this was happening, a long string of NPEs constantly filled up console.

7:52:09 PM
CONSOLE:
WARN]: java.lang.NullPointerException

 

[Joeri]

Here is a screenshot. http://i.imgur.com/uwns1tg.png Tabbychat is consolidating hundreds of the messages and still being spammed. Around the time this was happening, a long string of NPEs constantly filled up console.

7:52:09 PM
CONSOLE:
WARN]: java.lang.NullPointerException

Weirdt, btw the player in the screenshot is using fullbright... Is that allowed on ur server?

 

[Snhnry]

Weirdt, btw the player in the screenshot is using fullbright... Is that allowed on ur server?

The major focus of the server is building, so many of our players use it while building in dark places.

 

[HiddenCloud]

Here is a screenshot. http://i.imgur.com/uwns1tg.png Tabbychat is consolidating hundreds of the messages and still being spammed. Around the time this was happening, a long string of NPEs constantly filled up console.

7:52:09 PM
CONSOLE:
WARN]: java.lang.NullPointerException

I think the nullpointer was caused by a world being unloaded thus becoming null, and since there were no null checks in the day/night cycling method I think that's the cause for the message spamming. I wrote a better day/night cycling that will most likely resolve the bug if MistPhizzle merges the commit.

 

[Snhnry]

I think the nullpointer was caused by a world being unloaded thus becoming null, and since there were no null checks in the day/night cycling method I think that's the cause for the message spamming. I wrote a better day/night cycling that will most likely resolve the bug if MistPhizzle merges the commit.

That would be consistent with what was happening. Our bending world unloads when empty.

 

[Mist]

This has been fixed as of 1.3.0 BETA 8

 

[sehunpark]

This has been fixed as of 1.3.0 BETA 8

This seems to still occur on my server with version 1.3.0 BETA 10. I never saw it when I had multiple bendings (Either a coincidence or some odd occasion.), but when I became a waterbender only, I was spammed by these messages on the client. Nothing in the console though.

 

[SamuraiSnowman]

This seems to still occur on my server with version 1.3.0 BETA 10. I never saw it when I had multiple bendings (Either a coincidence or some odd occasion.), but when I became a waterbender only, I was spammed by these messages on the client. Nothing in the console though.

We got a new code for it in BETA 10, that made it so it spams every night and day change.. I recommend removing the permissions for the message until the bug is fixed (That's what my server did).

 

[AlexTheCoder]

#ThreeTimesReWritingIt

 

[bordalandsdude19]

We got a new code for it in BETA 10, that made it so it spams every night and day change.. I recommend removing the permissions for the message until the bug is fixed (That's what my server did).

What's the permission node.

 

[HiddenCloud]

The last person who reported this said that he got an error when the spamming occured, can you please provide the error, it can be helpful when fixing the problem.

 

[AlexTheCoder]

Guys this has been patched soooo